internal/apps: move setup-smoke-test #2871
Merged
+254
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move setup-smoke-test from internal/apps/setup-smoke-test to internal/setup-smoke tests. This allows the other internal/apps to use the latest version of go. We want this because these apps are often used to test the latest new features which may depend on new go version. They are also used for screenshots where we don't want to show an old go version. setup-smoke-test is serving a different purpose and needs to be tested against the minimum version of Go that we support. So move it to a separate location and give it its own go.mod file.
6 tasks
felixge
added a commit
that referenced
this pull request
Sep 17, 2024
Remove go version workaround. This will be addressed by merging #2871 first. Use go1.23.0 instead of go1.23 since the latter includes pre-release versions which we don't want here.
RomainMuller
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move setup-smoke-test from internal/apps/setup-smoke-test to internal/setup-smoke tests. This allows the other internal/apps to use the latest version of go. We want this because these apps are often used to test the latest new features which may depend on new go version. They are also used for screenshots where we don't want to show an old go version.
setup-smoke-test is serving a different purpose and needs to be tested against the minimum version of Go that we support. So move it to a separate location and give it its own go.mod file.
What does this PR do?
Motivation
Reviewer's Checklist
Unsure? Have a question? Request a review!